Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Data package depends on Networking package? #31

Open
hoangelec opened this issue Oct 22, 2023 · 2 comments
Open

[Question] Data package depends on Networking package? #31

hoangelec opened this issue Oct 22, 2023 · 2 comments

Comments

@hoangelec
Copy link

First of all, thank you for your brilliant work publishing your article and the example source code.

I have a question regarding the diagram in your article, according to your diagram, the dependency direction should be from the "Networking" package to "Data" package
image

However in your example code, Data is depending on Networking, is this a violation of dependency direction?
image

@dodomarocgenex
Copy link

The dependency of the network layer on the data repository comes from this method: APIEndpoints.getMovies(with moviesRequestDTO: MoviesRequestDTO)

@kudoleh
Copy link
Owner

kudoleh commented Oct 22, 2023

Hello, yes Data Layer Module can dependent on Networking Module. It needs it in order to fetch data from network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants