rotate

[finalbytes]

Hi Ania,

i love your projects, really simple, elegant, and created with ease... :-) well done!

But i found a issue in the rotate function, i a iTetromino is dropping, i move him againt the right side, and i want to rotate the block. I'll see 2 blocks on the right side and 2 blocks on the left side, 1 line below them. I think they need an extra validation if we can rotate this shape, or you need to shift the shape 2 squares to the left. I think the same is happening on the left side. Probably other shapes will have the same issue.

[mavima]

Thanks a lot for the nice project Ania, it was a pleasure to practice with it!

I solved the rotation issue with adding "nextRotation" to the function and checking that it doesn't touch both first and last square of the lines:

function rotate() {
// check if there is room also after the rotate
let nextCurrent = []
if (currentRotation <= 2) {
nextCurrent = tetrominoes[random][currentRotation + 1]
} else {
nextCurrent = tetrominoes[random][0]
}
let Edge = nextCurrent.some(index => (currentPosition + index) % width === width - 1) && nextCurrent.some(index => (currentPosition + index) % width === 0)

if(!Edge) {
undraw()
currentRotation ++
if (currentRotation === current.length) {
currentRotation = 0
}
current = tetrominoes[random][currentRotation]
draw()
}
}

[loulou1994]

Great! This actually fixes the issue better than what's proposed in the pull request section. Thanks @mavima !.