Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch tests that require external services (ssh/minio) to integration tests #569

Open
detiber opened this issue Mar 9, 2018 · 1 comment
Open

Switch tests that require external services (ssh/minio) to integration tests #569

detiber opened this issue Mar 9, 2018 · 1 comment
Labels
CI/CD Improve Testing

Comments

@detiber
Copy link
Member

detiber commented Mar 9, 2018

Tests accessing external services should be run as separate integration tests, rather than as unit tests.

It would also be beneficial to not require pre-configured and running external containers to provide these services, but rather to spin up services as part of the test or test harness setup.
@detiber detiber added the Testing label Mar 9, 2018
@xmudrii xmudrii mentioned this issue Mar 9, 2018
Closed
@krisnova
Copy link
Member

I agree - we should move all integrations tests out of the main repo and not as unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD Improve Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@detiber @krisnova @xmudrii