Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge KUBEVIRT_TAG & KUBEVIRT_VERSION within our automation scripts #943

Open
lyarwood opened this issue Apr 3, 2024 · 1 comment
Open
Assignees
Labels

Comments

@lyarwood
Copy link
Member

lyarwood commented Apr 3, 2024

What happened:

$subject, this is trivial but we are pinning to a specific KubeVirt release using two different env vars at the moment. Merge these and use the existing latest_version logic

$ git grep -E '(KUBEVIRT_TAG|KUBEVIRTCI_TAG|KUBEVIRT_VERSION)'
automation/common/deploy-kubevirt-and-cdi.sh:oc apply -n $NAMESPACE -f "https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/kubevirt-operator.yaml"
automation/common/deploy-kubevirt-and-cdi.sh:oc apply -n $NAMESPACE -f "https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/kubevirt-cr.yaml"
automation/common/versions.sh:KUBEVIRT_VERSION=$(latest_version "kubevirt" "kubevirt")
hack/kubevirt.sh:export KUBEVIRT_TAG="${KUBEVIRT_TAG:-main}"
hack/kubevirt.sh:    git clone --depth 1 --branch "${KUBEVIRT_TAG}" https://github.com/kubevirt/kubevirt.git "${_base_dir}/_kubevirt"
hack/kubevirtci.sh:export KUBEVIRTCI_TAG=${KUBEVIRTCI_TAG:-$(curl -sfL https://storage.googleapis.com/kubevirt-prow/release/kubevirt/kubevirtci/latest)}
hack/kubevirtci.sh:    git clone --depth 1 --branch "${KUBEVIRTCI_TAG}" https://github.com/kubevirt/kubevirtci.git "${_cluster_up_dir}"

What you expected to happen:
A clear and concise description of what you expected to happen.

How to reproduce it (as minimally and precisely as possible):
Steps to reproduce the behavior.

Additional context:
Add any other context about the problem here.

Environment:

  • KubeVirt version (use virtctl version): N/A
  • Kubernetes version (use kubectl version): N/A
  • VM or VMI specifications: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Install tools: N/A
  • Others: N/A
@lyarwood
Copy link
Member Author

lyarwood commented Apr 3, 2024

/assign @lyarwood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant