Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable arm64 operator build #803

Closed
wants to merge 1 commit into from
Closed

fix: enable arm64 operator build #803

wants to merge 1 commit into from

Conversation

codingben
Copy link
Member

@codingben codingben commented Dec 25, 2023 •
edited

What this PR does / why we need it:

Enable developer building operator on an arm64 machine as an additional option.

Jira-Url: https://issues.redhat.com/browse/CNV-36775

Which issue(s) this PR fixes:

Fixes #802

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 25, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 0xfelix for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S labels Dec 25, 2023
@codingben codingben marked this pull request as draft December 25, 2023 17:20
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 25, 2023
@codingben codingben force-pushed the CNV-36775 branch 2 times, most recently from 89e8446 to fae7c1c Compare December 25, 2023 17:24
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 25, 2023
@codingben
Copy link
Member Author

/cc @akrejcir

@codingben
fix: enable arm64 operator build
c8df213 
Enable developer building operator on an
arm64 machine as an additional option.

Jira-Url: https://issues.redhat.com/browse/CNV-36775

Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codingben
codingben commented Dec 28, 2023
View reviewed changes
Dockerfile
@@ -3,7 +3,7 @@ FROM registry.access.redhat.com/ubi9/ubi-minimal as builder

RUN microdnf install -y make tar gzip which && microdnf clean all

RUN curl -L https://go.dev/dl/go1.20.11.linux-amd64.tar.gz | tar -C /usr/local -xzf -
Copy link
Member Author

@codingben codingben Dec 28, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akrejcir @0xFelix How do you suggest to check if it's arm64 or amd64 here? Isn't architecture usually based on base images? e.g. Golang amd64 [1] or arm64 [2].

[1] https://hub.docker.com/r/amd64/golang
[2] https://hub.docker.com/r/arm64v8/golang

Copy link
Collaborator

@akrejcir akrejcir Jan 2, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be some way to detect which architecture is used and download the right package based on that.
This was the reason why I dropped my original PR. I didn't want to spend too much time figuring this out, if no one would use it.

We stopped using golang images from docker hub, because there was a rate limit on them (0fd2e73), and now we probably don't want to depend on docker.
We cannot simply install golang package using microdnf, because a package with the needed version may not yet be available. We hit this problem in: #335 .

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codingben
Copy link
Member Author

I'm closing this PR because it's not needed - I'm using VM to build SSP.

@codingben codingben closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Developer can't build SSP on an arm64 machine
3 participants
@codingben @kubevirt-bot @akrejcir