Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle paginated results in e2e-upgrade-functests #794

Open
0xFelix opened this issue Dec 22, 2023 · 2 comments
Open

Handle paginated results in e2e-upgrade-functests #794

0xFelix opened this issue Dec 22, 2023 · 2 comments

Comments

@0xFelix
Copy link
Member

0xFelix commented Dec 22, 2023

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind enhancement

What happened:

https://github.com/kubevirt/ssp-operator/blob/54285313efecb017c47744dda5b666bdfd4a1c56/automation/e2e-upgrade-functests/run.sh#L24C20-L24C86

This scripts queries for release branches and by default there is a limit of 30 items per page.
Since dependabot started creating a lot of branches, the branches we are looking for are no longer returned on page one. This resulted in the CI failing.

See #792

What you expected to happen:

The script should handle paginated results, see https://docs.github.com/en/rest/branches/branches?apiVersion=2022-11-28#list-branches--parameters

How to reproduce it:

Anything else we need to know?:

Environment:

  • KubeVirt version (use virtctl version):
  • Kubernetes version (use kubectl version):
  • SSP Operator version:
  • VM or VMI specifications:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
@akrejcir
Copy link
Collaborator

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants