Allow image Docker registry redefining for the entire package

[danil-smirnov]

Why should it be implemented?

In many enterprise environments, image downloads are allowed from internal servers only due to security measurements. Now it's impossible to redefine image registries for all the charts, i.e. nats-io chart lacks this option (nats-io/k8s#378).

Describe the improvement

Ideally it should be a global global.imageRegistry parameter to define it across all the charts, but at least a working image.registry parameter for every chart would help. Maybe all external charts could be adopted and installed from local folders rather than from remote repositories.

Additional context
Add any other context about the problem here if needed.

[vsukhin]

Thank you, Danil. Good points!

[danil-smirnov]

Hi @vsukhin
I'm afraid this PR does nothing for this issue, as it only creates a secret for a particular registry while images still refer to the public registries and there is no way to redefine them globally.
Also mentioned above external subchart nats still doesn't support a registry parameter.
Because of this, we are unable to use Testkube helm charts in our organization.
Maybe you can check Bitnami charts to learn how to do this properly?

[vsukhin]

Ok, I will reopen this request, we will look at it later

[vsukhin]

It's almost done. But we're waiting for changes from NATs, if they implement them. If not, then we need to add thier chart to our repo

[ypoplavs]

Hello @danil-smirnov ,

nats now allows redefining registries per image (not globally yet). Please see the PR: nats-io/k8s#606
So now you can install TK using your own images:

helm install testkube helm-charts/testkube --namespace testkube --create-namespace --set nats.nats.image.registry=REGISTRY_NAME --set nats.natsbox.image.registry=REGISTRY_NAME --set nats.reloader.image.registry=REGISTRY_NAME --set nats.exporter.image.registry=REGISTRY_NAME --set mongodb.global.imageRegistry=REGISTRY_NAME --set global.imageRegistry=REGISTRY_NAME --set preUpgradeHook.enabled=false --set preUpgradeHook.serviceAccount.create=false --debug

nats values define registry for all nats-related images;
mongodb defines mongo registry;
global.imageRegistry defined registry for Testkube-related images.

Also please set --set preUpgradeHook.enabled=false and --set preUpgradeHook.serviceAccount.create=false so that a Mongo upgrade job won’t launch into your cluster. This is used for downgrade Mongo version from 12 to 11 for the users that installed our chart with 12 version earlier.

Please try and let us know about the results.