Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets in an IPv6 primary cluster fail #1520

Open
MaxRink opened this issue Mar 18, 2024 · 1 comment
Open

WebSockets in an IPv6 primary cluster fail #1520

MaxRink opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working hub Indicates an issue or PR is related to the Hub. triage/accepted Indicates an issue or PR is ready to be actively worked on. worker Indicates an issue or PR is related to the worker.

Comments

@MaxRink
Copy link

MaxRink commented Mar 18, 2024

Describe the bug
We have Cluster that are either IPv6 only or IPv6 primary.
In those clusters the hub cant connect to the websocket of the workers.

2024-03-18T10:45:12Z INF server/controllers/socket.go:130 > Connecting to the worker at: url=ws://2a01:598:7e0:15::8:30001/ws?node=ship-lab-1-lx7qj&q=&worker=2a01%3A598%3A7e0%3A15%3A%3A8%3A30001
2024-03-18T10:45:12Z ERR server/controllers/socket.go:134 > WebSocket client dial: error="dial tcp: address 2a01:598:7e0:15::8:30001: too many colons in address"

Provide more information
On-Prem, upstream K8s 1.27.10
With Coil + Calico as CNI
To Reproduce
Steps to reproduce the behavior:

  1. install kubeshark on an IPv6 primary cluster
  2. Check the hub logs

Expected behavior
the hub can correctly use the websocket to the node agent

@corest corest self-assigned this Mar 18, 2024
@mertyildiran mertyildiran assigned mertyildiran and unassigned corest Mar 18, 2024
@mertyildiran
Copy link
Member

@MaxRink thank you so much for reporting the issue!

We've realized that the method that builds the address of the workers does not have the IPv6 support. We patched it in a way that if it's IPv6, it will be like [2a01:598:7e0:15::8]:30001 instead of 2a01:598:7e0:15::8:30001. The fix will be there in the next release.

@mertyildiran mertyildiran added bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on. hub Indicates an issue or PR is related to the Hub. worker Indicates an issue or PR is related to the worker. labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hub Indicates an issue or PR is related to the Hub. triage/accepted Indicates an issue or PR is ready to be actively worked on. worker Indicates an issue or PR is related to the worker.
Projects
None yet
Development

No branches or pull requests

3 participants