Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maroto to v2.0.0 #1458

Open
johnfercher opened this issue Oct 28, 2023 · 11 comments
Open

Update maroto to v2.0.0 #1458

johnfercher opened this issue Oct 28, 2023 · 11 comments
Labels
feature New feature or request

Comments

@johnfercher
Copy link
Contributor

Overview

Hello, I'm the creator of johnfercher/maroto and I see that you use the old version of maroto to generate a report in your project. I would like to purpose to use kubescape as a pilot to maroto v2. The project just reached the first beta version (after 42 alpha versions). The v2 is easier than v1, runs twice as fast as v1, allows unit tests and have a bunch of new features.

Problem

Solution

I would refactor the current code to use the v2, keeping the exactly same PDF structure that is generated today. I will create unit tests to warrant that the PDF is correct and I will provide benchmarks of the time execution of the report.

Alternatives

Additional context

I will also provide support to your project, helping with any issues and even adding features to maroto v2 to meet kubescape need.

@johnfercher johnfercher added the feature New feature or request label Oct 28, 2023
@alegrey91
Copy link
Collaborator

Hi @johnfercher !! This is a great initiative :)
Your help is really appreciated and welcomed.
Your library is really cool, so I would also thank you on behalf of all our community for your work.

@johnfercher
Copy link
Contributor Author

Thanks for the kind words, kubescape is awesome too. I will start this update soon.

@alegrey91
Copy link
Collaborator

Hey @johnfercher, question for you. Does your company use kubescape?
We are searching for adopters to be added in the ADOPTERS.md file. This would help a lot our project.
Let me know :)

@ankur0904
Copy link

@johnfercher @alegrey91 I want to work on this issue.

@alegrey91
Copy link
Collaborator

@johnfercher @alegrey91 I want to work on this issue.

Hi @ankur0904, @johnfercher is already working on it.

@dwertent
Copy link
Contributor

dwertent commented Nov 6, 2023

I see the version was bumped to v1 and not to v2

@ankur0904
Copy link

@dwertent Should I go for updating the version to v2?

@alegrey91
Copy link
Collaborator

I see the version was bumped to v1 and not to v2

I think this was before opening this issue. @johnfercher correct me if I'm wrong.

@johnfercher
Copy link
Contributor Author

johnfercher commented Nov 7, 2023

  1. @alegrey91, I don't know if my company use kubescape. I don't work with infra directly.
  2. @dwertent I just updated from 0.42.0 to the latest v1 stable.
  3. @ankur0904 you can update the library if you want, I don't think I will be able to start the migration from v1 to v2 in kubescape this week. (I'm on a very busy week currently)
    • The only thing is that the v2 changed a lot. If you have any doubt just chat me.

@ankur0904
Copy link

@johnfercher Where I have had the opportunity to have a chat with you?

@alegrey91
Copy link
Collaborator

@johnfercher would you like to take care of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants