Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the Kubescape survey #1409

Open
craigbox opened this issue Oct 6, 2023 · 11 comments
Open

Add link to the Kubescape survey #1409

craigbox opened this issue Oct 6, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@craigbox
Copy link
Contributor

craigbox commented Oct 6, 2023

Until the Message of the Day work is complete, we should display a link to our project survey at the bottom of every time through the kubescape CLI.

Please fill a 3 question survey to help the Kubescape project! https://kubescape.io/project/survey/

I suggest you use the following logic:

  • if connected to a provider, display the provider text
  • else, display the survey link
@craigbox craigbox added the bug Something isn't working label Oct 6, 2023
@prady0t
Copy link

prady0t commented Oct 6, 2023

Can I work on this?

@prady0t
Copy link

prady0t commented Oct 6, 2023

Are we supposed to put the link somewhere around here?
image

@matthyx
Copy link
Contributor

matthyx commented Oct 9, 2023

Hi @prady0t Craid said instead of the provider text, so it should replace :

View results
────────────
Now, take your scan results to the next level with actionable insights on ARMO Platform.

Sign up for free here - https://cloud.armosec.io/repository-scanning/74ec6f9c-f2f2-47fa-b755-6b88e8a1289a

@prady0t
Copy link

prady0t commented Oct 11, 2023

Hey @matthyx. Can you refer to areas in the codebase from where the provider text is coming from. I found out this function

func (report *ReportEventReceiver) DisplayMessage() {

Is responsible for printing the provider text.

@matthyx
Copy link
Contributor

matthyx commented Oct 11, 2023

https://github.com/kubescape/kubescape/blob/master/core/core/initutils.go#L75
When we don't submit results (which is the use case) we provide the message directly to the mock reporter.

@VaibhavMalik4187
Copy link
Contributor

@matthyx Can I work on this?

@matthyx
Copy link
Contributor

matthyx commented Nov 22, 2023

sure, thanks!

@VaibhavMalik4187
Copy link
Contributor

Can you please share a command which can be used to test the fix? Thanks

VaibhavMalik4187 added a commit to VaibhavMalik4187/kubescape that referenced this issue Nov 22, 2023
This change will display the kubescape project survery link at the
bottom instead of the provider text.

Fixes: kubescape#1409

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
@matthyx matthyx closed this as completed Mar 5, 2024
@craigbox
Copy link
Contributor Author

Looks like the PR to close this wasn't actually merged?

@craigbox craigbox reopened this Mar 12, 2024
@matthyx
Copy link
Contributor

matthyx commented Mar 12, 2024

Looks like the PR to close this wasn't actually merged?

@slashben said we no longer need this, do you have a different opinion?

@craigbox
Copy link
Contributor Author

not one as important as that, I just wanted to check it wasn't a flaw of automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants