Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check new colours work OK with white background #1385

Open
craigbox opened this issue Sep 11, 2023 · 3 comments
Open

Check new colours work OK with white background #1385

craigbox opened this issue Sep 11, 2023 · 3 comments
Labels
feature New feature or request

Comments

@craigbox
Copy link
Contributor

Overview

https://twitter.com/Didicodes/status/1699084012050850047/photo/2

@craigbox craigbox added the feature New feature or request label Sep 11, 2023
@XDRAGON2002
Copy link
Contributor

XDRAGON2002 commented Sep 11, 2023

I suppose a major scope of improvement for this lies in replacing the yellow text we have.

It'd be better to instead have a contrast neutral colour which looks good on both black and white, all the other existing colours look good for both the backgrounds as far as I can tell (other than yellow).

@craigbox
Copy link
Contributor Author

Is it practical to detect "light mode" and "dark mode" and use a different colour throughout?

@XDRAGON2002
Copy link
Contributor

We could do that.
It should be possible, though I haven't taken a look at the "how" to make it possible, I do believe there must exist a library to tell us what the current theme of the terminal is.

The only thing I have in mind is, what would the probable output look like on a white background? It would be a bummer if we refactor everything and realize it looks bad on a white background regardless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants