From a804853c2c0fa96a08257fed5f049c6bfe6bfdf8 Mon Sep 17 00:00:00 2001 From: Michal Wozniak Date: Fri, 8 Mar 2024 07:36:16 +0100 Subject: [PATCH] Review remarks --- content/en/docs/concepts/workloads/controllers/job.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/content/en/docs/concepts/workloads/controllers/job.md b/content/en/docs/concepts/workloads/controllers/job.md index 479b780ee5b4c..4d3c0b84ea5dd 100644 --- a/content/en/docs/concepts/workloads/controllers/job.md +++ b/content/en/docs/concepts/workloads/controllers/job.md @@ -1011,7 +1011,7 @@ status: {{< feature-state for_k8s_version="v1.30" state="alpha" >}} {{< note >}} -You can only set `ManagedBy` field on Jobs if you enable the `JobManagedBy` +You can only set the `managedBy` field on Jobs if you enable the `JobManagedBy` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) (disabled by default). {{< /note >}} @@ -1019,12 +1019,13 @@ You can only set `ManagedBy` field on Jobs if you enable the `JobManagedBy` This feature allows you to disable the built-in Job controller, for a specific Job, and delegate reconciliation of the Job to an external controller. -By setting a custom value of the `spec.managedBy` field - any value +You indicate the controller that reconciles the Job by setting a custom value +for the `spec.managedBy` field - any value other than `kubernetes.io/job-controller` - you indicate the controller which reconciles the Job. The value of the field is immutable. {{< note >}} -When using this feature make sure the controller indicated by the field is +When using this feature, make sure the controller indicated by the field is installed, otherwise the Job may not be reconciled at all. {{< /note >}} @@ -1043,8 +1044,8 @@ Finally, when developing an external Job controller make sure it does not use th {{< warning >}} If you are considering to disable the `JobManagedBy` feature gate, or to -downgrade the cluster to a version without the feature gate enabled, inspect -there are no jobs with a custom value of the `spec.managedBy` field. If there +downgrade the cluster to a version without the feature gate enabled, check if +there are jobs with a custom value of the `spec.managedBy` field. If there are such jobs, there is a risk that they might be reconciled by two controllers after the operation: the built-in Job controller and the external controller indicated by the field value.