diff --git a/pkg/controller/job/job_controller_test.go b/pkg/controller/job/job_controller_test.go index 89482f80d1c6..ada5605a7dea 100644 --- a/pkg/controller/job/job_controller_test.go +++ b/pkg/controller/job/job_controller_test.go @@ -2406,9 +2406,13 @@ func TestSyncJobWhenManagedByLabel(t *testing.T) { actual = job return job, nil } - sharedInformerFactory.Batch().V1().Jobs().Informer().GetIndexer().Add(job) + if err := sharedInformerFactory.Batch().V1().Jobs().Informer().GetIndexer().Add(job); err != nil { + t.Fatalf("error %v while adding the %v job to the index", err, klog.KObj(job)) + } - manager.syncJob(context.TODO(), testutil.GetKey(job, t)) + if err := manager.syncJob(context.TODO(), testutil.GetKey(job, t)); err != nil { + t.Fatalf("error %v while reconciling the job %v", err, testutil.GetKey(job, t)) + } if diff := cmp.Diff(tc.wantStatus, actual.Status); diff != "" { t.Errorf("Unexpected job status (-want,+got):\n%s", diff) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index d89f8484c0a4..53dc1d31374c 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -354,7 +354,7 @@ const ( // kep: https://kep.k8s.io/4368 // beta: v1.30 // - // Allows to deleted reconciliation of the Job to another controller. + // Allows to delegate reconciliation of a Job object to an external controller. JobManagedByLabel featuregate.Feature = "JobManagedByLabel" // owner: @mimowo