Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all constants to a single const ( #1400

Closed
yagonobre opened this issue Feb 11, 2019 · 4 comments · Fixed by kubernetes/kubernetes#73942
Closed

Move all constants to a single const ( #1400

yagonobre opened this issue Feb 11, 2019 · 4 comments · Fixed by kubernetes/kubernetes#73942
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@yagonobre
Copy link
Member

Move all const on file cmd/kubeadm/app/cmd/options/constant.go to a single const (

i.e:

- // APIServerAdvertiseAddress flag sets the IP address the API Server will advertise it's listening on. Specify '0.0.0.0' to use the address of the default network interface.
- const APIServerAdvertiseAddress = "apiserver-advertise-address"

- // APIServerBindPort flag sets the port for the API Server to bind to.
- const APIServerBindPort = "apiserver-bind-port"
+ const (
+    // APIServerAdvertiseAddress flag sets the IP address the API Server will advertise it's listening on. Specify '0.0.0.0' to use the address of the default network interface.
+    APIServerAdvertiseAddress = "apiserver-advertise-address"
+
+    // APIServerBindPort flag sets the port for the API Server to bind to.
+    const APIServerBindPort = "apiserver-bind-port"
+)

/kind cleanup
/priority backlog
/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@yagonobre:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Move all const on file cmd/kubeadm/app/cmd/options/constant.go to a single const (

i.e:

- // APIServerAdvertiseAddress flag sets the IP address the API Server will advertise it's listening on. Specify '0.0.0.0' to use the address of the default network interface.
- const APIServerAdvertiseAddress = "apiserver-advertise-address"

- // APIServerBindPort flag sets the port for the API Server to bind to.
- const APIServerBindPort = "apiserver-bind-port"
+ const (
+    // APIServerAdvertiseAddress flag sets the IP address the API Server will advertise it's listening on. Specify '0.0.0.0' to use the address of the default network interface.
+    APIServerAdvertiseAddress = "apiserver-advertise-address"
+
+    // APIServerBindPort flag sets the port for the API Server to bind to.
+    const APIServerBindPort = "apiserver-bind-port"
+)

/kind cleanup
/priority backlog
/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 11, 2019
@yagonobre yagonobre changed the title Move all constants on to a single const ( Move all constants to a single const ( Feb 11, 2019
@MalloZup
Copy link

markdown doesn't work for title 😄

@rumshenoy
Copy link

Hi @yagonobre, I would like to work on this issue.

Can you tell me how I can test this after I finish moving all constants into one const?

Thank you.

@yagonobre
Copy link
Member Author

Thanks @rumshenoy,
you can run the tests ./build/run.sh make test WHAT=./cmd/kubeadm/app/cmd/, and try to build kubeadm ./build/run.sh make build kubeadm

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 11, 2019
@timothysc timothysc added this to the v1.14 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants