Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guestbook-go not working as is #506

Open
AntoineToussaint opened this issue Aug 3, 2023 · 12 comments
Open

guestbook-go not working as is #506

AntoineToussaint opened this issue Aug 3, 2023 · 12 comments
Assignees
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@AntoineToussaint
Copy link

AntoineToussaint commented Aug 3, 2023

There are two issues:

  • Docker build fails:
 => ERROR [stage-0 2/5] RUN go get github.com/codegangsta/negroni            github.com/gorilla/mux            github.com/xyproto/simpleredis                                              4.5s
------
 > [stage-0 2/5] RUN go get github.com/codegangsta/negroni            github.com/gorilla/mux            github.com/xyproto/simpleredis:
4.463 package github.com/xyproto/simpleredis: no Go files in /go/src/github.com/xyproto/simpleredis

Fix: add /v2 to simpleredis version.

  • Docker image referenced in Replica Controller aims replica redis client at deprecated service name redis-slave:
curl localhost:3000/rpush/k/v
PANIC: dial tcp: lookup redis-slave on 10.96.0.10:53: no such host
goroutine 5 [running]:

Fix: Deploy v4 version of registry.k8s.io/guestbook based on current main.go and update Kubernetes manifest.

I would do a PR but I am not sure what the process is to update the Docker image.

@dkwgit
Copy link

dkwgit commented Oct 11, 2023

Also, the Makefile should be fixed. make build builds the image with staging-k8s.gcr.io but the manifest file for guestbook controller points to registry.k8s.io.

@lopter
Copy link

lopter commented Dec 15, 2023

I also just ran into that issue, it was confusing.

@Martande8055
Copy link

I also faced the same issue.
I like to work on this issue, Please assign it to me.

@pranav-pandey0804
Copy link

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Mar 27, 2024
@Martande8055
Copy link

hey, @pranav-pandey0804, can I work on this?

@pranav-pandey0804
Copy link

@Martande8055 sure, you don't need to ask to work on a issue

@pranav-pandey0804
Copy link

Just comment '/assign' and it will be assigned to you automatically

@pranav-pandey0804
Copy link

@Martande8055 also you need to sign the CLA if you haven't already and make sure to follow community guidelines

@pranav-pandey0804
Copy link

You can refer to this - https://github.com/kubernetes/kubernetes/community

@Martande8055
Copy link

/assign

@Martande8055
Copy link

Thank you so much @pranav-pandey0804 for guidance me.

@bansalji02
Copy link
Contributor

/assign

k8s-ci-robot added a commit that referenced this issue May 20, 2024
issue #506--->fixed the redis issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests

7 participants