Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology Aware Subsetting #2004

Closed
robscott opened this issue Sep 22, 2020 · 16 comments · Fixed by #2666
Closed

Topology Aware Subsetting #2004

robscott opened this issue Sep 22, 2020 · 16 comments · Fixed by #2666
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@robscott
Copy link
Member

robscott commented Sep 22, 2020

Enhancement Description

This is an evolution of #536. I think this is different enough that it deserves a new KEP + issue, but I'm open to feedback on that.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 22, 2020
@robscott
Copy link
Member Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 22, 2020
@robscott
Copy link
Member Author

/assign

@kikisdeliveryservice
Copy link
Member

Thanks for this, as a reminder by Enhancements Freeze (Oct 6th), in order to be included in the release:

  • The KEP must be merged in an implementable state
  • The KEP must have test plans
  • The KEP must have graduation criteria.

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 23, 2020
@kikisdeliveryservice kikisdeliveryservice added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 23, 2020
@kikisdeliveryservice
Copy link
Member

FTR: Double checked the inflight PR and it meets the above criteria (and wow those test plans!!!). It just needs to merge by next week Tuesday October 6th

@mzohreva
Copy link

mzohreva commented Oct 1, 2020

It would be useful to support same-node as well. A typical use case for same-node: Prefer is a database service. Application Pods would prefer to use the co-located database endpoint if possible.

Also, it would be useful to provide an option for advanced users to have more control over when traffic spills over to other regions. The current proposal makes it hard to reason about when spill over happens without knowing the details of the heuristics used.

@robscott
Copy link
Member Author

robscott commented Oct 5, 2020

@mzohreva Thanks for the feedback! Do you mind commenting on #2005 so we can keep all feedback in one place?

@kikisdeliveryservice
Copy link
Member

@robscott just as a reminder, your PR (#2005 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

@kikisdeliveryservice
Copy link
Member

#2005 merged! Updating sheet now 🎉

@kikisdeliveryservice
Copy link
Member

Hey @robscott

Please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks!
Kirsten

@kcmartin
Copy link

Hello @robscott , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@kcmartin
Copy link

kcmartin commented Nov 2, 2020

Hi @robscott

The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze
Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@robscott
Copy link
Member Author

robscott commented Nov 5, 2020

Hey @kcmartin and @kikisdeliveryservice, unfortunately I don't think I'll have enough time to get this in for the 1.20 cycle. Will be trying to get it in early in 1.21 instead.

@kikisdeliveryservice
Copy link
Member

Thanks for the update @robscott

@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Nov 6, 2020
@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Nov 6, 2020
@robscott
Copy link
Member Author

KEP has been updated: #2153

@robscott robscott changed the title Topology Aware Routing Topology Aware Subsetting Jan 28, 2021
@robscott
Copy link
Member Author

robscott commented Jan 28, 2021

PR for 1.21 release cycle: #2355

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants