Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and enhance JSONPath template syntax #1886

Closed
povsister opened this issue Jul 7, 2020 · 9 comments
Closed

Clarify and enhance JSONPath template syntax #1886

povsister opened this issue Jul 7, 2020 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@povsister
Copy link

povsister commented Jul 7, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note): Clarify and enhance JSONPath template syntax
  • Kubernetes Enhancement Proposal: KEP-1886: Clarify and enhance JSONPath template syntax #1887
  • Primary contact (assignee): @povsister
  • Responsible SIGs: sig-api-machinery
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) TBD
    • Beta release target (x.y) TBD
    • Stable release target (x.y) TBD

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig api-machinery
/kind feature

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 7, 2020
@povsister
Copy link
Author

cc @liggitt
You might have some interest on this.

@kikisdeliveryservice
Copy link
Member

Hi @povsister

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@povsister
Copy link
Author

@kikisdeliveryservice

After discussing with reviewers on the pull-request. I am afraid I can not make it happen in 1.20.
Because the purpose of this enhancement request has been changed from "enhance existing implementation of JSONPath" to "introduce a brand-new implementation of JSONPath"

Kubernetes generally release every 3 month. I see 1.19 released on late Aug, which means code-freeze for 1.20 will probably be early in Nov.
I am a little busy than expected recently, so I can't promise providing a brand-new JSONPath implementation for entire Go community before Nov.

However, I think it's possible to catch up 1.21, I can update the schedule for beta to 1.21 if you wish.

@kikisdeliveryservice
Copy link
Member

Thank you for the update @povsister !

Please update the description as you see fit. We will check back in with you in 1.21 and do let us know if anything changes between now and then.

For ref here is the current 1.20 schedule

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 14, 2020
@povsister
Copy link
Author

No problem.
Thanks for your attention. @kikisdeliveryservice

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2020
@povsister
Copy link
Author

/remove-lifecycle stale
I am really busy at the end of year...
Mark it as TODO item in 2021Q1. (For myself)

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2020
@deads2k
Copy link
Contributor

deads2k commented Jan 19, 2021

I don't think I want to define a new superset of jsonpath for use in kubernetes. I am interested in documenting the current capabilities we have in user level documentation for kubectl and for the API surface we use in places like CRD specs. If someone needs more power, they can pull the json locally and use the library of their choosing.

I don't think user documentation and openapi documentation to clarify what we support require a KEP.

/close

I think it would take a fair amount to convince sig-apimachinery/sig-cli to extend the jsonpath we allow today, but if there are currently unworkable bugs, try pinging in the #sig-api-machinery slack channel and point back to the particular features of the kep you made which are required individually.

@k8s-ci-robot
Copy link
Contributor

@deads2k: Closing this issue.

In response to this:

I don't think I want to define a new superset of jsonpath for use in kubernetes. I am interested in documenting the current capabilities we have in user level documentation for kubectl and for the API surface we use in places like CRD specs. If someone needs more power, they can pull the json locally and use the library of their choosing.

I don't think user documentation and openapi documentation to clarify what we support require a KEP.

/close

I think it would take a fair amount to convince sig-apimachinery/sig-cli to extend the jsonpath we allow today, but if there are currently unworkable bugs, try pinging in the #sig-api-machinery slack channel and point back to the particular features of the kep you made which are required individually.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

5 participants