Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release gke-gcloud-auth-plugin separately in this repo similar to how aws-iam-authenticator is released. #433

Open
upodroid opened this issue Dec 20, 2022 · 10 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@upodroid
Copy link
Member

Installing gke-gcloud-auth-plugin is very hard(as in too many extra deps) today as you would need to install it either via apt or install the entire gcloud SDK as described here. https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke

The code lives in this repo, it shouldn't be hard to attach a goreleaser to it and release it.

https://github.com/kubernetes/cloud-provider-gcp/tree/master/cmd/gke-gcloud-auth-plugin

I need to add the binary to an alpine image and it is proving tricky as Google doesn't release all the goarchs that we need.

https://github.com/GoogleCloudPlatform/cloud-sdk-docker/blob/master/Dockerfile (for some reason, this is an amd64 image only 😒 )

https://packages.cloud.google.com/apt/dists/cloud-sdk-bullseye/main

kubernetes/test-infra#28277
kubernetes/test-infra#28142

https://issuetracker.google.com/issues/263033287

@aojea what do you think?

@aojea
Copy link
Member

aojea commented Dec 20, 2022

I'm not really familiar with the workflows in this repo and its constraints to publish binaries,
maybe @mikedanese knows better?

@BenTheElder
Copy link
Member

@aojea anyone else that might know?

@sftim
Copy link

sftim commented May 10, 2023

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label May 10, 2023
@BenTheElder
Copy link
Member

I don't think this is in scope for SIG Release as an out of tree binary. Subprojects are responsible for their own releases.

@BenTheElder
Copy link
Member

It's a bit early still but there are binaries uploaded to staging on postsubmit as of today. It needs more cleanup and then they can be promoted with file promoter hopefully.

Been following up with @ndixita and @aojea on this.

@upodroid
Copy link
Member Author

@justinsb ^

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 27, 2024
@BenTheElder
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 28, 2024
@BenTheElder
Copy link
Member

I lost track of exactly what happened here but I think these are being copied to staging at least.

The gap around advertising releases remains and is something I'm discussing with the involved teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

6 participants