Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for certManager in helmChart and CLI #1326

Open
pragmaticivan opened this issue Sep 7, 2023 · 2 comments
Open

Support for certManager in helmChart and CLI #1326

pragmaticivan opened this issue Sep 7, 2023 · 2 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pragmaticivan
Copy link

What would you like to be added:
I would like to add a new property such as:

certificates:
  certManager:
    enabled: true

ref

Parameter Type Default Description
certificates.certManager.caSecretName string "metrics-server-ca" Secret name where the CA is stored (generatedby cert-manager or user given)
certificates.certManager.enabled bool false Enables Cert-manager for certificate management
certificates.certManager.generateCA bool true Generates a self-signed CA with Cert-manager. If generateCA is false, the secret with the CA has to be annotated with cert-manager.io/allow-direct-injection: "true"
certificates.certManager.secretTemplate object {} Add labels/annotations to secrets created by Certificate resources docs
certificates.mountPath string "/certs" Path where metrics-server TLS certificates are mounted
certificates.secretName string "metrics-server-certs" Secret name to be mounted with metrics-server TLS certificates

This would integrate metrics-server with certManager automatically instead of providing caBundle manually.

KEDA templates for ref: https://github.com/kedacore/charts/tree/main/keda/templates/cert-manager

Why is this needed:
To improve setup and operation.

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2023
@dashpole
Copy link

/assign @stevehipwell
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 21, 2023
@stevehipwell
Copy link
Contributor

#1288 should cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants