Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some validations to CEL #463

Closed
nayihz opened this issue Dec 6, 2022 · 5 comments · Fixed by #2008
Closed

Migrate some validations to CEL #463

nayihz opened this issue Dec 6, 2022 · 5 comments · Fixed by #2008
Assignees
@IrvingMg
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@nayihz
Copy link
Contributor

nayihz commented Dec 6, 2022

What would you like to be cleaned:
we can remove the webhooks in favor of CEL once 1.24 reaches EoL https://kubernetes.io/releases/

Why is this needed:
Since Kubernetes 1.25, we can use CEL validation rules to implement a few common immutability patterns directly in the manifest for a CRD.
ref: https://kubernetes.io/blog/2022/09/29/enforce-immutability-using-cel/
@nayihz nayihz added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 6, 2022
@nayihz nayihz mentioned this issue Dec 6, 2022
Merged
@kerthcet
Copy link
Contributor

kerthcet commented Dec 6, 2022

/kind deprecation
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 6, 2022
@alculquicondor
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 6, 2022
@alculquicondor alculquicondor mentioned this issue Dec 6, 2022
Closed
@kannon92 kannon92 mentioned this issue Apr 10, 2023
Closed
@alculquicondor alculquicondor mentioned this issue May 10, 2023
Merged
@alculquicondor
Copy link
Contributor

Maybe we cannot fully replace defaulting, but at least we can replace validation.

/assign trasc

@IrvingMg IrvingMg mentioned this issue Apr 2, 2024
Merged
@IrvingMg
Copy link
Contributor

IrvingMg commented Apr 8, 2024

/assign @IrvingMg

@trasc trasc removed their assignment Apr 8, 2024
This was referenced Apr 9, 2024
Merged
Merged
Merged
@IrvingMg IrvingMg mentioned this issue Apr 18, 2024
Merged
@alculquicondor
Copy link
Contributor

/retitle Migrate some validations to CEL

Since we couldn't delete the webhooks entirely due to some limitations of CEL.

We requested some improvements upstream kubernetes/kubernetes#124490

@k8s-ci-robot k8s-ci-robot changed the title remove the webhooks in favor of CEL once 1.24 reaches EoL Migrate some validations to CEL Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IrvingMg IrvingMg

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CEL rules to Workload epam/kubernetes-kueue
6 participants
@alculquicondor @kerthcet @k8s-ci-robot @IrvingMg @trasc @nayihz