Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sidecar containers #2068

Closed
alculquicondor opened this issue Apr 25, 2024 · 3 comments · Fixed by #2099
Closed

Support for sidecar containers #2068

alculquicondor opened this issue Apr 25, 2024 · 3 comments · Fixed by #2099
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@alculquicondor
Copy link
Contributor

What happened:

We are currently treating sidecar containers as regular initContainers. However, sidecar containers continue running until the pod completes https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/

Note that this feature is beta since kubernetes v1.29

What you expected to happen:

To account for the usage of sidecar containers.

Anything else we need to know?:

The function should look similar to this: https://github.com/kubernetes/kubernetes/blob/ae02f87bb47cd3e10e702ffe19225ff2dba73578/pkg/api/v1/resource/helpers.go#L50

However, we should not directly use that function, as it doesn't have stability guarantees and the kubernetes module might have non-trivial dependencies.

We could, in parallel, start a different effort to move this function to some other place more reusable, like https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/component-helpers/scheduling

Environment:

  • Kubernetes version (use kubectl version): v.129
  • Kueue version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@alculquicondor alculquicondor added the kind/bug Categorizes issue or PR as related to a bug. label Apr 25, 2024
@alculquicondor
Copy link
Contributor Author

/assign @trasc

@alculquicondor
Copy link
Contributor Author

I opened the issue upstream kubernetes/kubernetes#124537

@IrvingMg
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants