Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework implementation for multiple admissions per cycle #1867

Open
alculquicondor opened this issue Mar 18, 2024 · 1 comment
Open

Rework implementation for multiple admissions per cycle #1867

alculquicondor opened this issue Mar 18, 2024 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be cleaned:

Re-design the logic that allows multiple admissions to happen per cycle without incurring in over admission.

I think a simpler approach would be along the lines of modifying the snapshot (add admitted workloads and remove preempted workloads within the cycle) and checking if the incoming workload still fits. There is a special case for workloads needing preemption where there are no candidates for preemption. I think we can add a smaller fake workload that reserves space for the workload without going beyond the nominal quotas.

Why is this needed:

The current logic has been reworked multiple times with various pros and cons.

Now it's very hard to follow.

@alculquicondor alculquicondor added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 18, 2024
@alculquicondor
Copy link
Contributor Author

cc @yaroslava-serdiuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant