Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to defer preemption when using admission checks #1677

Open
3 tasks
alculquicondor opened this issue Jan 31, 2024 · 2 comments · May be fixed by #1178
Open
3 tasks

Ability to defer preemption when using admission checks #1677

alculquicondor opened this issue Jan 31, 2024 · 2 comments · May be fixed by #1178
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

The ability for an admission check to influence when preemptions happen (anytime vs after the check has passed).

Why is this needed:

It might be useful if an admission check could take a long time to be satisfied, so that preempting early is not very useful.
However, it's unclear whether the usefulness of this feature outweights the complexity of moving the preemption logic outside of the admission loop. Especially as we start thinking of #62 and #998.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.
@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 31, 2024
This was referenced Jan 31, 2024
Closed
Open
@trasc trasc mentioned this issue Feb 5, 2024
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2024
@tenzen-y
Copy link
Member

tenzen-y commented May 1, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
4 participants
@alculquicondor @k8s-ci-robot @k8s-triage-robot @tenzen-y