Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube_controller_pod_eviction_timeout no longer works #7112

Closed
holmesb opened this issue Jan 7, 2021 · 0 comments · Fixed by #7114
Closed

kube_controller_pod_eviction_timeout no longer works #7112

holmesb opened this issue Jan 7, 2021 · 0 comments · Fixed by #7114
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@holmesb
Copy link
Contributor

holmesb commented Jan 7, 2021

Controller manager's --pod-eviction-timeout argument hasn't worked since Kubernetes v1.13. So unless you've added TaintBasedEvictions to your pods, they will take five minutes to failover when a node goes down. Setting global eviction timers is now done using the api server's
- --default-not-ready-toleration-seconds=
- --default-unreachable-toleration-seconds=

parameters. Since the kube_controller_pod_eviction_timeout variable is a string eg "5m", whereas the above expect an integer representing the number of seconds, should create two new variables: kube_apiserver_pod_eviction_not_ready_timeout and kube_apiserver_pod_eviction_unreachable_timeout.
@holmesb holmesb added the kind/bug Categorizes issue or PR as related to a bug. label Jan 7, 2021
holmesb pushed a commit to holmesb/kubespray that referenced this issue Jan 7, 2021
Fixed issue kubernetes-sigs#7112. Created new API Server vars that re…
3274212 
…place defunct Controller Manager one

Signed-off-by: Brendan Holmes <brendan.holmes.ext@berenberg.com>
@holmesb holmesb mentioned this issue Jan 7, 2021
Merged
holmesb added a commit to holmesb/kubespray that referenced this issue Jan 8, 2021
@holmesb
Fixed issue kubernetes-sigs#7112.  Created new API Server vars that r…
264c51f 
…eplace defunct Controller Manager one

Signed-off-by: Brendan Holmes <5072156+holmesb@users.noreply.github.com>
k8s-ci-robot pushed a commit that referenced this issue Jan 8, 2021
@holmesb
Fixed issue #7112.  Created new API Server vars that replace defunct …
b0ad8ec 
…Controller Manager one (#7114)

Signed-off-by: Brendan Holmes <5072156+holmesb@users.noreply.github.com>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this issue Jan 17, 2021
@holmesb @LuckySB
Fixed issue kubernetes-sigs#7112.  Created new API Server vars that r…
949a286 
…eplace defunct Controller Manager one (kubernetes-sigs#7114)

Signed-off-by: Brendan Holmes <5072156+holmesb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore ability to set pod eviction timer holmesb/kubespray
1 participant
@holmesb