Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up tasks for conformance reporting #3050

Open
xtineskim opened this issue May 3, 2024 · 2 comments
Open

Follow up tasks for conformance reporting #3050

xtineskim opened this issue May 3, 2024 · 2 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@xtineskim
Copy link
Contributor

xtineskim commented May 3, 2024

These are some follow up tasks noted after the merging of #2874

What would you like to be added:
From reviewers (thank you all for the suggestions!):

There are also some things I noticed that might be helpful:

  • having a basic conformance yaml in the repo as well. We wouldn't have to have thrown the list of features (i have a feeling we might forget to add to that list down the road), and listing out the core conformance tests as well maybe? Might be helpful down the line when more supportedFeatures are added, and more xRoutes are reported
  • have a better way to show partial support, and a different symbol to show skippedTests.
@xtineskim xtineskim added the kind/documentation Categorizes issue or PR as related to documentation. label May 3, 2024
@youngnick
Copy link
Contributor

One hundred percent agreed on trying to do something else with the list of features - ideally we would read this out of the Go source files for the test suite, but I think that may require porting the generation script to Go, sadly.

Also agreed on everything else.

@xtineskim
Copy link
Contributor Author

xtineskim commented May 14, 2024

also the format of <MESH | GATEWAY>-<HTTP | GRPC | TLS> in the reports have to be changed (for v1.1.0)
#3019

Wondering for this, if an implementation were to run this against an older version of gateway api (for example v1.0.0), should this be reflected in the past reports, or only affect v1.1.0 and greater?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

2 participants