Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance utils/http MakeRequestAndExpectEventuallyConsistentResponse hardcodes http scheme #2960

Open
briantkennedy opened this issue Apr 11, 2024 · 0 comments
Open

Conformance utils/http MakeRequestAndExpectEventuallyConsistentResponse hardcodes http scheme #2960

briantkennedy opened this issue Apr 11, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@briantkennedy
Copy link
Contributor

What happened:

I noticed that MakeRequestAndExpectEventuallyConsistentResponse hard codes the http scheme.

What you expected to happen:

The scheme and should be derived from ExpectedResponse.Request.Protocol.
@briantkennedy briantkennedy added the kind/bug Categorizes issue or PR as related to a bug. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briantkennedy