Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.14.0] Unit tests on endpoint_test.go need a renaming #4339

Closed
leonardocaylent opened this issue Mar 26, 2024 · 0 comments · Fixed by #4462
Closed

[v0.14.0] Unit tests on endpoint_test.go need a renaming #4339

leonardocaylent opened this issue Mar 26, 2024 · 0 comments · Fixed by #4462
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@leonardocaylent
Copy link
Contributor

leonardocaylent commented Mar 26, 2024 •
edited

What happened:
The unit test on master could contribute to confusion.
We can't have CNAME and A records with the same name

What you expected to happen:
Fix/modify/add comments to the unit test so
Clarify if the FilterEndpointsByOwnerID function will be able to accept A records and CNAME records with the same name
@leonardocaylent leonardocaylent added the kind/bug Categorizes issue or PR as related to a bug. label Mar 26, 2024
@leonardocaylent leonardocaylent changed the title [v0.14.0] Invalid unit tests on endpoint_test.go [v0.14.0] Unit tests on endpoint_test.go need a renaming Mar 29, 2024
@leonardocaylent leonardocaylent mentioned this issue Apr 12, 2024
Merged
2 tasks
@leonardocaylent leonardocaylent mentioned this issue May 11, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add clarification to endpoint unit tests leonardocaylent/external-dns
1 participant
@leonardocaylent