Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the minimum CPU platform in GCPMachine spec #1040

Open
itspngu opened this issue Oct 10, 2023 · 7 comments
Open

Allow specifying the minimum CPU platform in GCPMachine spec #1040

itspngu opened this issue Oct 10, 2023 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@itspngu
Copy link

itspngu commented Oct 10, 2023

/kind feature

Describe the solution you'd like
The GCPMachine spec allows specifying machine types, but some setups necessitate requesting a certain minimum CPU platform. This should be an optional field in the GCPMachine spec.

Anything else you would like to add:
GCP docs: https://cloud.google.com/compute/docs/instances/specify-min-cpu-platform#rest_1

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 10, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@itspngu
Copy link
Author

itspngu commented Jan 30, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@jayesh-srivastava
Copy link
Member

Hi @itspngu , is this still open, if yes then I can take this up.

@itspngu
Copy link
Author

itspngu commented Feb 1, 2024

Hi @itspngu , is this still open, if yes then I can take this up.

Hey @jayesh-srivastava! Yes, I just currently lack the time to work on it - feel free and thank you :)

The usecase I implied in the original description but somehow failed to point towards explicitly was using Confidential Compute with Cluster-API, you have to request "AMD Milan" as minimum CPU platform for that.

@jayesh-srivastava
Copy link
Member

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2024
@itspngu
Copy link
Author

itspngu commented May 2, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants