DeleteSnapshot RPC is sent to CSI driver when clone was in progress.

[Madhu-1]

What happened:

DeleteSnapshot RPC is sent to the CSI driver when the clone is in progress.

Note: The clone was created in a different namespace using https://kubernetes.io/blog/2023/01/02/cross-namespace-data-sources-alpha/#create-a-persistentvolumeclaim-by-using-cross-namespace-data-source and i think

external-snapshotter/pkg/common-controller/snapshot_controller.go

Line 866 in 0654851

func (ctrl *csiSnapshotCommonController) isVolumeBeingCreatedFromSnapshot(snapshot *crdv1.VolumeSnapshot) bool {

is only applicable when clone and snapshot are in same namespace.

What you expected to happen:

Dont send the DeleteSnapshot RPC clone when clone was in progress.

How to reproduce it:
Follow the steps in https://kubernetes.io/blog/2023/01/02/cross-namespace-data-sources-alpha/#create-a-persistentvolumeclaim-by-using-cross-namespace-data-source and ensure to delete the volume snapshot when the clone was in progress.

Anything else we need to know?:

Environment:

• Driver version:
• Kubernetes version (use kubectl version):
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[Madhu-1]

@xing-yang any thoughts?

[xing-yang]

I think the cross namespace feature was not there when this was implemented. It makes sense to fix it.
@Madhu-1 Are you interested in working on a fix?

[liangyuanpeng]

I want to work for it and need some guide.
@Madhu-1 @xing-yang

It's need the external-snapshotter support feature-gates and check isVolumeBeingCreatedFromSnapshot from all of namespace if CrossNamespaceVolumeDataSource=true. Remind me if i missed something,thanks!

here is the simple code:

  CrossNamespaceVolumeDataSource := true
  if CrossNamespaceVolumeDataSource {
    pvcList, err = ctrl.pvcLister.List(labels.Everything())
  }else{
    pvcList, err = ctrl.pvcLister.PersistentVolumeClaims(snapshot.Namespace).List(labels.Everything())
  }

/assign

[Madhu-1]

@xing-yang i missed the ping, sorry for that, as @liangyuanpeng has already shown interest , please go ahead :)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Madhu-1]

I want to work for it and need some guide. @Madhu-1 @xing-yang

It's need the external-snapshotter support feature-gates and check isVolumeBeingCreatedFromSnapshot from all of namespace if CrossNamespaceVolumeDataSource=true. Remind me if i missed something,thanks!

here is the simple code:

  CrossNamespaceVolumeDataSource := true
  if CrossNamespaceVolumeDataSource {
    pvcList, err = ctrl.pvcLister.List(labels.Everything())
  }else{
    pvcList, err = ctrl.pvcLister.PersistentVolumeClaims(snapshot.Namespace).List(labels.Everything())
  }

/assign

@xing-yang are you okay with introducing a new flag or any other alternative do you suggest?

[Madhu-1]

/reopen

[k8s-ci-robot]

@Madhu-1: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Madhu-1]

/remove-lifecycle rotten

[Madhu-1]

/assign