Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate SourceVolumeMode in individual VolumeSnapshotContents #1004

Open
xing-yang opened this issue Feb 9, 2024 · 3 comments
Open

Populate SourceVolumeMode in individual VolumeSnapshotContents #1004

xing-yang opened this issue Feb 9, 2024 · 3 comments
Assignees

Comments

@xing-yang
Copy link
Collaborator

What happened:
There is a TODO here to Populate this field when volume mode conversion is enabled by default. Now that volume mode conversion is enabled by default, we should populate this field.
https://github.com/kubernetes-csi/external-snapshotter/blob/v7.0.0/pkg/sidecar-controller/groupsnapshot_helper.go#L448

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • Driver version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@xing-yang
Copy link
Collaborator Author

/assign @RaunakShah

@Madhu-1
Copy link
Contributor

Madhu-1 commented Apr 5, 2024

@xing-yang Are you mentioned about prevent-volume-mode-conversion flag? if yes, it is only part of the snapshot-controller argument, as we don't have any flag in csi-snapshotter to check if the mode is enabled should we add a new flag to the csi-snapshotter as well?

@xing-yang
Copy link
Collaborator Author

@Madhu-1 I'm thinking we should probably get rid of this flag completely. @RaunakShah has brought this up. I need to double check on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants