Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly indicate external-provisioner go.mod version by major for proper module resolution #1110

Open
jakobmoellerdev opened this issue Nov 14, 2023 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@jakobmoellerdev
Copy link

jakobmoellerdev commented Nov 14, 2023

What happened:

I tried importing the command of external-provisioner with go get github.com/kubernetes-csi/external-provisioner@v3.6.2 but couldn't because the go.mod does not properly include the version path suffix at https://github.com/kubernetes-csi/external-provisioner/blob/master/go.mod#L1

What you expected to happen:

I expect the version suffix to follow the major version (currently /v3), just like for external-snapshotter: https://github.com/kubernetes-csi/external-snapshotter/blob/master/go.mod#L1

How to reproduce it:

Attempt to build a go module and depend on any package of external-provisioner with go get github.com/kubernetes-csi/external-provisioner@v3.6.2

Anything else we need to know?:

Even though there aren't a lot of use cases, this is common go hygiene and shouldn't be too hard to fix.

Environment:

  • Driver version: 3.6.2
@wenwutang1
Copy link

hello

@msau42
Copy link
Collaborator

msau42 commented Mar 9, 2024

/help

@k8s-ci-robot
Copy link
Contributor

@msau42:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants