Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose metadata of VolumeContentSource(VS/PVC) to SP plugin #1069

Closed
jeffyjf opened this issue Oct 27, 2023 · 4 comments · May be fixed by #1070
Closed

Expose metadata of VolumeContentSource(VS/PVC) to SP plugin #1069

jeffyjf opened this issue Oct 27, 2023 · 4 comments · May be fixed by #1070
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jeffyjf
Copy link

jeffyjf commented Oct 27, 2023

Is your feature request related to a problem?/Why is this needed

Some SPs cannot delete VolumeSnapshot before the Volume that based on the VolumeSnapshot be deleted, Such as openstack cinder. This is our bug description: kubernetes/cloud-provider-openstack#2294.

Describe the solution you'd like in detail

I want to synchronously add finalizer to VolumeSnapshot when create PersistentVolume based on this VolumeSnapshot to resolve above issue. But I can't get enough informations (such as name and namespace) about the VolumeSnapshot in CreateVolume function, CreateVolumeRequest just provide VolumeContentSource kind and the changed name.

Describe alternatives you've considered

I tried to register a watcher to wath the creation event of PersistentVolume, I add a finalizer to VolumeSnapshot when I receive the event, But it is asynchronous, It seem like is unsafety. I also tried to implement a admission webhook to do this, duo to it is kind of complexity and it complicate the deployment, I don't like it.

Additional context

We also support create PersistentVolumeCliam base on anthor PersistentVolumeCliam, maybe it will have the same issue with other SPs. So, I propose that add csi.storage.k8s.io/vsc/name and csi.storage.k8s.io/vsc/namespace to CreateVolumeRequest parameters when flag --extra-create-metadata be set to make it more general.
This was referenced Oct 27, 2023
Open
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 1, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass source VS/PVC metadata to plugin by request parameters jeffyjf/external-provisioner
3 participants
@jeffyjf @k8s-ci-robot @k8s-triage-robot