Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on k8s.io/kubernetes #1067

Open
msau42 opened this issue Oct 26, 2023 · 5 comments
Open

Remove dependencies on k8s.io/kubernetes #1067

msau42 opened this issue Oct 26, 2023 · 5 comments

Comments

@msau42
Copy link
Collaborator

msau42 commented Oct 26, 2023

What happened:
Packages from k8s.io/kubernetes were not designed to be imported and adds a lot of complexity to our dependency management where we need to inject "replace" statements into go.mod. It is also not supported by dependabot, which we would like to use to help automate our releases.

It looks like the dependencies are all coming from the e2e tests, which are importing the kubernetes e2e test framework libraries:
https://github.com/search?q=repo%3Akubernetes-csi%2Fexternal-provisioner+k8s.io%2Fkubernetes+path%3A*.go&type=code

@xing-yang I think we may want to move this out to its own repo, or maybe into the csi-test repo?

@xing-yang
Copy link
Contributor

@msau42 Right, we need to think about this. Maybe csi-test repo is a better choice rather than creating another repo.

@xing-yang
Copy link
Contributor

cc @RaunakShah

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 1, 2024
@msau42
Copy link
Collaborator Author

msau42 commented Mar 5, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants