Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install as host process on windows node and not requiring csi-proxy #481

Open
himanshuz2 opened this issue May 25, 2022 · 7 comments
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@himanshuz2
Copy link

Is your feature request related to a problem?/Why is this needed
with hostprocess now available, csi-proxy should not be needed to run this driver on windows nodes

Describe the solution you'd like in detail
a daemonset that can deploy this driver on every windows node on the cluster.

Describe alternatives you've considered
login to every added windows node and install csi-proxy using the methods described
modify the base image for windows node pool to install csi-proxy

Additional context

@andyzhangx
Copy link
Member

related to this PR: kubernetes-csi/csi-proxy#179

@andyzhangx andyzhangx added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label May 29, 2022
@himanshuz2
Copy link
Author

@andyzhangx
Copy link
Member

Found the yaml file to install csi-proxy https://github.com/kubernetes-sigs/cluster-api-provider-azure/tree/main/templates/addons/windows/csi-proxy

@himanshuz2 so run following command on k8s 1.23+ cluster would work?

kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/cluster-api-provider-azure/main/templates/addons/windows/csi-proxy/csi-proxy.yaml

@himanshuz2
Copy link
Author

Found the yaml file to install csi-proxy https://github.com/kubernetes-sigs/cluster-api-provider-azure/tree/main/templates/addons/windows/csi-proxy

@himanshuz2 so run following command on k8s 1.23+ cluster would work?

kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/cluster-api-provider-azure/main/templates/addons/windows/csi-proxy/csi-proxy.yaml

Yes.

@Termibg22
Copy link

Found the yaml file to install csi-proxy https://github.com/kubernetes-sigs/cluster-api-provider-azure/tree/main/templates/addons/windows/csi-proxy

@himanshuz2 so run following command on k8s 1.23+ cluster would work?

kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/cluster-api-provider-azure/main/templates/addons/windows/csi-proxy/csi-proxy.yaml

Yes.

When i try to install it on a RKE2 cluster with 2 windows nodes the pod gives the following error:

I0907 03:07:19.474978 7664 main.go:64] Starting CSI-Proxy Server ... I0907 03:07:19.474978 7664 main.go:65] Version: v1.1.1-0-gc16d19a I0907 03:07:19.474978 7664 main.go:84] Working directories: %v[C:\var\lib\kubelet] 2023-09-07T03:07:19.482378900-07:00 panic: ([]error) 0xc000004c00 2023-09-07T03:07:19.482652900-07:00 2023-09-07T03:07:19.482652900-07:00 goroutine 1 [running]: main.main() 2023-09-07T03:07:19.482652900-07:00 /mnt/vss/_work/1/go/src/github.com/kubernetes-csi/csi-proxy/cmd/csi-proxy/main.go:73 +0x1fd

@andyzhangx andyzhangx reopened this Sep 11, 2023
@andyzhangx andyzhangx added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 11, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

5 participants