New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KuberhealthyCheck
status
field instead of separate KuberhealthyState
object
#1120
Comments
Fixes kuberhealthy#1120 Signed-off-by: Ugur Zongur <ugur.zongur@thetradedesk.com>
Fixes kuberhealthy#1120 Signed-off-by: Ugur Zongur
Fixes kuberhealthy#1120 Signed-off-by: Ugur Zongur
Fixes kuberhealthy#1120 Signed-off-by: Ugur Zongur
Fixes kuberhealthy#1120 Signed-off-by: Ugur Zongur <104643878+ugurzongur@users.noreply.github.com>
Fixes kuberhealthy#1120 Signed-off-by: Ugur Zongur <104643878+ugurzongur@users.noreply.github.com>
LGTM. But the code heavily depend on the khstate. |
See: #1061 (comment) |
I feel that following the kstatus spec would also be helpful for flux health check.
It seems like a good thing to follow as per the motivation of the spec. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment on the issue or this will be closed in 15 days. |
I think there are a few reasons we are considering revising the If we do a CRD refactor, it seems prudent to think about getting rid of the |
Describe the feature you would like and why you want it
Currently the status of a
KuberhealthyCheck
is stored in a separateKuberhealthyState
object of the same name. Is there a good reason why this isn't instead stored in astatus
field of theKuberhealthyCheck
itself, as is customary in Kubernetes?Additional context
The separate object makes it impossible to create a custom Argo CD health check for the
KuberhealthyCheck
, which would allow Argo CD to show the application as unhealthy if a check is failing.The text was updated successfully, but these errors were encountered: