Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GH workflow): migrate presubmit tests to GH actions #10752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(GH workflow): migrate presubmit tests to GH actions #10752

wants to merge 1 commit into from

Conversation

shruti2522
Copy link
Contributor

@shruti2522 shruti2522 commented Apr 25, 2024 •
edited

*Description of your changes:
Fixes #10746.
Added presubmit.yml to github workflow.

Checklist:

CC @rimolive

@shruti2522
feat(GH workflow): migrate presubmit tests to GH actions
87bfe44 
Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ironpan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow Google OSS Prow
Copy link

Hi @shruti2522. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DharmitD
Copy link
Contributor

/ok-to-test

DharmitD
DharmitD reviewed May 19, 2024
View reviewed changes
.github/workflows/presubmit.yml
branches:
- master

jobs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You currently don't have a mechanism to replicate the run_if_changed condition from Prow. To address this, you could add a step at the start of each job using a script or a pre-built action like dorny/paths-filter@v2 to determine if the job should run based on changed files.

@DharmitD
Copy link
Contributor

@shruti2522 have you tried testing this GH Action on your fork? If yes, could you please provide the link to a successful run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@chensun chensun Awaiting requested review from chensun

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees
No one assigned
Labels
ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate presubmit tests to GH Actions
2 participants
@shruti2522 @DharmitD