From 8a112edff12417454de4534a5c3111ba547dc2a2 Mon Sep 17 00:00:00 2001 From: kuizhiqing Date: Thu, 29 Feb 2024 12:24:30 +0000 Subject: [PATCH] no overwrite when run launcher as worker --- pkg/controller/mpi_job_controller.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/pkg/controller/mpi_job_controller.go b/pkg/controller/mpi_job_controller.go index 0958668a..cc09eaa8 100644 --- a/pkg/controller/mpi_job_controller.go +++ b/pkg/controller/mpi_job_controller.go @@ -1534,12 +1534,13 @@ func (c *MPIJobController) newLauncherPodTemplate(mpiJob *kubeflow.MPIJob) corev case kubeflow.MPIImplementationMPICH: container.Env = append(container.Env, mpichEnvVars...) } - - container.Env = append(container.Env, - // We overwrite these environment variables so that users will not - // be mistakenly using GPU resources for launcher due to potential - // issues with scheduler/container technologies. - nvidiaDisableEnvVars...) + if !ptr.Deref(mpiJob.Spec.RunLauncherAsWorker, false) { + container.Env = append(container.Env, + // We overwrite these environment variables so that users will not + // be mistakenly using GPU resources for launcher due to potential + // issues with scheduler/container technologies. + nvidiaDisableEnvVars...) + } c.setupSSHOnPod(&podTemplate.Spec, mpiJob) // Submit a warning event if the user specifies restart policy for