Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm values to reflect sample-config.yml #1724

Open
dirsigler opened this issue Apr 16, 2024 · 3 comments
Open

Update Helm values to reflect sample-config.yml #1724

dirsigler opened this issue Apr 16, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dirsigler
Copy link

Feature Request

Short Description

Add the values of the sample-config.yml in the default Helm values..

Is your feature request related to a problem? Please describe the use case.

No.

Describe the solution you'd like

If there are no objections based on previous design decisions, I would suggest to add the provided KubeArmorConfig from the sample-config.yml to the default values of the Helm Chart.
This reduces a manuel step in the installation and also provides more content to the values.yml, improving the overall default setup.

Describe alternatives you've considered

Ignore my proposed change 😀.

@dirsigler dirsigler added the enhancement New feature or request label Apr 16, 2024
@dirsigler
Copy link
Author

If there are no objections, I would like to contribute the proposed changes to the project.

@dirsigler
Copy link
Author

In addition it seems the getting-started guide and the Helm deployment guide somewhat differ.

So they would need an udpate too.

@rksharma95
Copy link
Collaborator

hi @dirsigler i think --autoDeploy=true is the configuration that you're looking for.
https://github.com/kubearmor/KubeArmor/tree/main/deployments/helm/KubeArmorOperator#values
helm default values already matches with sample-config values, also the image configuration is same as operator deploys stable version by default.

to eliminate the additional step of creating kubearmorconfig CR we can update getting started guide to deploy operator with --autoDeploy=true wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants