Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Visibility Documentation #1617

Open
daemon1024 opened this issue Feb 8, 2024 · 6 comments · May be fixed by #1747
Open

Update Visibility Documentation #1617

daemon1024 opened this issue Feb 8, 2024 · 6 comments · May be fixed by #1747
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@daemon1024
Copy link
Member

https://github.com/kubearmor/KubeArmor/blob/main/getting-started/kubearmor_visibility.md

The visibility guide is outdated,

KubeArmor has 2 sources of setting and configuring visibility

  1. Namespace annotation ( As explained in https://github.com/kubearmor/KubeArmor/blob/main/getting-started/kubearmor_visibility.md#updating-namespace-visibility)
  2. Config Map (Not documented)

We talk about pod/node level annotations in Visibility Doc but they are not respected anymore, we need to remove that.

Note:
There might be a chance to implement pod level visibility again with #1310 but that documentation will be handled when implemented

@daemon1024 daemon1024 added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Feb 8, 2024
@AryanBakliwal
Copy link

Hi, I would like to work on this issue. Please assign it to me :)

@rootxrishabh
Copy link
Member

Hey @AryanBakliwal thanks for the interest. Let me know if you have any questions!

@daemon1024
Copy link
Member Author

Hey @AryanBakliwal, any updates here. Anything we can help with?

@AryanBakliwal
Copy link

Hi @daemon1024, I had a talk with @rootxrishabh regarding this and I am still working on this. I’m new to KubeArmor so it is taking time, will open a PR soon :)

@AllenOps08
Copy link

@rootxrishabh @AryanBakliwal Are you still working on this issue ?I would like to takeover if not!

@rootxrishabh
Copy link
Member

Hey @AllenOps08, showing interest is good enough. You can start working on this.

@Ishaanj18 Ishaanj18 linked a pull request May 4, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants