Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Protocol support in kube-vip #184

Closed
sandys opened this issue Mar 11, 2021 · 2 comments
Closed

Proxy Protocol support in kube-vip #184

sandys opened this issue Mar 11, 2021 · 2 comments
Labels

Comments

@sandys
Copy link

sandys commented Mar 11, 2021

Is your feature request related to a problem? Please describe.
k3s-io/k3s#2997 (comment)
moby/moby#39465
moby/moby#25526
traefik/traefik-helm-chart#380

Getting real client-ip is a very big issue that comes all over the place. The only real way to solve this in a scalable, standards compliant way is to inject Proxy Protocol headers

Describe the solution you'd like
Proxy protocol is a fully open standard and supported by most known network servers:

kube-vip should inject proxy protocol v2 headers into the requests.

@nickperry
Copy link

Kube-vip is not a proxy / load balancer - it's a control-plane component that provides VIPs. As it doesn't sit in the data path, I don't believe there's any scope for it to do anything with Proxy Protocol.

@thebsdbox
Copy link
Collaborator

Closing as stale, please re-open if there is a need in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants