Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodDisruptionBudget for fluentd #1520

Open
florianstoeber opened this issue Oct 10, 2023 · 1 comment
Open

PodDisruptionBudget for fluentd #1520

florianstoeber opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pinned

Comments

@florianstoeber
Copy link
Contributor

florianstoeber commented Oct 10, 2023

Is your feature request related to a problem? Please describe.
In maintenance situations (Kubernetes update, node-image update, etc.), too many fluentds may be drained from the nodes. This can lead to an overflow situation in the fluentds, and the stability of the logging system is not guaranteed.

Describe the solution you'd like
The FluentdSpec should be enhanced to have a pdb field. This can be configured optionally in the following regard and create a corresponding PDB for the fluentd Statefulset:

fluentd:
  pdb:
    minAvailable: 2
fluentd:
  pdb:
    minUnavailable: 10%

This should then lead to following PDB (as an example):

apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: <loggingRef>-fluentd
spec:
  minAvailable: 2
  selector:
    matchLabels:
      <labels of the fluentd Statefulset>
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: <loggingRef>-fluentd
spec:
  minUnavailable: 10%
  selector:
    matchLabels:
      <labels of the fluentd Statefulset>

Describe alternatives you've considered
An alternative for me is to create the PDB manually or with an umbrella helm-chart. There might also be other solutions, but creating a PDB for the component is the easiest and Kubernetes-native way to guarantee way availability of the fluentd Pods.

Additional context
https://kubernetes.io/docs/tasks/run-application/configure-pdb/#specifying-a-poddisruptionbudget

@aslafy-z aslafy-z added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 10, 2023
Copy link

stale bot commented Dec 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the wontfix This will not be worked on label Dec 9, 2023
@aslafy-z aslafy-z added pinned and removed wontfix This will not be worked on labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pinned
Projects
None yet
Development

No branches or pull requests

2 participants