Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM build, fix build on master #609

Closed
wants to merge 1 commit into from
Closed

Add ARM build, fix build on master #609

wants to merge 1 commit into from

Conversation

Jasstkn
Copy link

@Jasstkn Jasstkn commented Feb 7, 2023 •
edited

Signed-off-by: Mariia Kotliarevskaia mariia.kotliarevskaia@gmail.com

Hi. The build on master is broken due to upgrade of syncthing library.
This PR reverts this upgrade and also introduces the build for arm architecture.

fixes #607

make build-ci                                                                                                                          12:11:26 (doublecloud.teleport.sh-mdb-unstable:common5)
/Users/mariakot/go/bin/gox --ldflags "-w -X github.com/ksync/ksync/pkg/ksync.GitCommit=0ac7d7f -X github.com/ksync/ksync/pkg/ksync.BuildDate= -X github.com/ksync/ksync/pkg/ksync.VersionString=corrupted-version -X github.com/ksync/ksync/pkg/ksync.GoVersion=go1.16 -X github.com/ksync/ksync/pkg/ksync.GitTag= -X github.com/ksync/ksync/pkg/radar.GitCommit=0ac7d7f -X github.com/ksync/ksync/pkg/radar.BuildDate= -X github.com/ksync/ksync/pkg/radar.VersionString=corrupted-version -X github.com/ksync/ksync/pkg/radar.GoVersion=go1.16 -X github.com/ksync/ksync/pkg/radar.GitTag= " \
                --parallel=10 \
                --output="bin/{{ .Dir }}_{{ .OS }}_{{ .Arch }}" \
                -os="!netbsd !freebsd !openbsd" -arch="amd64" \
                ./cmd/...
Number of parallel builds: 10

-->   windows/amd64: github.com/ksync/ksync/cmd/radar
-->     linux/amd64: github.com/ksync/ksync/cmd/ksync
-->    darwin/amd64: github.com/ksync/ksync/cmd/ksync
-->     linux/amd64: github.com/ksync/ksync/cmd/radar
-->    darwin/amd64: github.com/ksync/ksync/cmd/radar
-->   windows/amd64: github.com/ksync/ksync/cmd/ksync
/Users/mariakot/go/bin/gox --ldflags "-w -X github.com/ksync/ksync/pkg/ksync.GitCommit=0ac7d7f -X github.com/ksync/ksync/pkg/ksync.BuildDate= -X github.com/ksync/ksync/pkg/ksync.VersionString=corrupted-version -X github.com/ksync/ksync/pkg/ksync.GoVersion=go1.16 -X github.com/ksync/ksync/pkg/ksync.GitTag= -X github.com/ksync/ksync/pkg/radar.GitCommit=0ac7d7f -X github.com/ksync/ksync/pkg/radar.BuildDate= -X github.com/ksync/ksync/pkg/radar.VersionString=corrupted-version -X github.com/ksync/ksync/pkg/radar.GoVersion=go1.16 -X github.com/ksync/ksync/pkg/radar.GitTag= " \
                --parallel=10 \
                --output="bin/{{ .Dir }}_{{ .OS }}_{{ .Arch }}" \
                -os="darwin linux" -arch="arm64" \
                ./cmd/...
Number of parallel builds: 10

-->     linux/arm64: github.com/ksync/ksync/cmd/radar
-->    darwin/arm64: github.com/ksync/ksync/cmd/radar
-->     linux/arm64: github.com/ksync/ksync/cmd/ksync
-->    darwin/arm64: github.com/ksync/ksync/cmd/ksync

@Jasstkn
Add ARM build, fix build on master
6e379b5 
Signed-off-by: Mariia Kotliarevskaia <mariia.kotliarevskaia@gmail.com>
@Jasstkn
Copy link
Author

Jasstkn commented Feb 8, 2023

@grampelberg @timfallmk hi. could you advise why the test fails?

@timfallmk
Copy link
Collaborator

timfallmk commented Feb 10, 2023 •
edited

@Jasstkn We wrote this project a significant time ago and it has has long been deprecated. With the move of Kubernetes from the docker-daemon to containerd its basic functions are no longer supported.

In order to work again it would need to be completely rewritten. It's been abandoned for some time. Thank you for your interest though.

@timfallmk timfallmk mentioned this pull request Feb 10, 2023
Open
@Jasstkn
Copy link
Author

Jasstkn commented Feb 10, 2023

@Jasstkn We wrote this project a significant time ago and it has has long been deprecated. With the move of Kubernetes from the docker-daemon to containerd its basic functions are no longer supported.

In order to work again it would need to be completely rewritten. It's been abandoned for some time. Thank you for your interest though.

In the current company we use the old version of Kubernetes therefore the project works okay. I didn't see any mention of deprecation of the project in its README. Anyway thanks for letting me know!

@timfallmk
Copy link
Collaborator

Personally I've gone back and forth about archiving this repo, but I didn't want to lock anyone out who might want to take up ownership.

If you want to compile this for an older version of k8s you're welcome to do so.

@davidxia davidxia mentioned this pull request Mar 1, 2023
Open
@Jasstkn Jasstkn closed this Mar 29, 2023
@tleerai
Copy link

tleerai commented Apr 7, 2023

Ah, it's too bad :/

@fordneild
Copy link

Are there any good alternatives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grampelberg grampelberg Awaiting requested review from grampelberg grampelberg is a code owner

@timfallmk timfallmk Awaiting requested review from timfallmk timfallmk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: any plans to provide darwin arm64 executable?
4 participants
@Jasstkn @timfallmk @tleerai @fordneild