New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KSThread causing a crash getting queue name #207
Comments
This is my #1 crash now, can someone please look at this issue? or should I make my own branch of this project? |
I've been too busy with work for the past few weeks (new job). If someone makes a PR, I'm usually quick to merge them! |
Okay, thanks! |
@ferrous777 any luck? i'm also seeing this crash. I can't figure out how to repro this issue, but it looks like the |
e8977a4 should fix this issue. It wasn't checking for a valid pointer before dereferencing. This is also tagged 1.15.5, and I'm pushing to cocoapods. |
@kstenerud Hi man, I've checked your this commit Didn't you get errors when building? |
Got the same error/crash, version:
logs:
|
I have just seen the same crash in KSCrash 1.15.18:
The crash is reported on this line, as per the OP:
With the CrashDoctor reporting:
The application stats indicate that the app was in the background. I'm not sure if that has any impact on this investigation! Given that I'm afraid I don't understand how |
Hi i have the same issue in one of our apps with sentry KSCrash Podfile.lock:
Best |
@oleksandrlysenkov are you able to reproduce the crash ? |
@Kmohamed Personally I'm not able to reproduce on my devices, but every day I receive log in Crashlytics about this bug and currently it's a most appearing crash on 2 of my projects. |
@oleksandrlysenkov a side question why you are using KSCrash and Crashlytics ? |
I have just had the crash happen to me! It occurred when foregrounding the app. The app crashed immediately upon foregrounding—the UI appeared briefly and then disappeared, as typical for a crash. Unfortunately it was on a debug build for which I don't have symbols, but the stack trace of thread 0 and the crashing thread show what the app was doing:
|
@Kmohamed We use Crashlytics for general crash-logging together with Fabric and KSCrash inside of other tools like XCGLogger |
We moved from Crashlytics to Sentry. All Crashlatics Sources are removed. The Crash also appears in XCode=>Organizer=>Crashes :: AppStore=> (a Released Version) => KSCrash ... All on Thread 3, all in KSCrash ksthread_getQueueName reffered to:
This Issue appears in our Sentry 10-20 Times a Day. It seems that our crashes happen after Out Of Memory Application Termination due Garbadge Collector is involved: "Attempted to dereference garbage pointer 0x16b717180." All Devices have low Memory e.g.: Memory | Total: 1.9 GB / Free: 55.8 MB / Usable: 1.7 GB And our Sentry additional Logging with Breadcrumbs show events in that order:
Sometimes (40-50% of all Reports) the Crash appears on: AppDelegate applicationWillResignActive. Than the User needs to restart the App twice or one User needed to restart the App 3 times. For Testing i could reproduce OOM App Termination by a second foreground App wich just eats memory like: https://stackoverflow.com/questions/18640414/ios-alloc-objects-until-didreceivememorywarning-is-called/18641099#18641099
Attention try this on Device, your simulator may shares memory with your host Mac. |
@kstenerud I think this an acceptable solution for this crash until someone find a better one #281 |
The crash still appears, @kstenerud hope you can find a solution for it. After an additional investigation I found, that crash appeared right after update from version 1.15.16 to 1.15.18. I'm not so good in ObjC, but logically this change caused the crash to appear - http://prntscr.com/jdpc70 http://prntscr.com/jdpcrd @Kmohamed I'm not sure how your Pull request can solve the problem, that appears in my app. Your change is on line 94 of KSCrash.c, but crash appears on line 87 Yet the only way how to avoid the crash, I suppose, is to use version 1.15.16 of KSCrash. |
I've got a crash report from iTunes Connect that has some more information in it that might be valuable. More info than I've seen before.
|
me too |
This is also our number one crash right now. |
This is top one crash of my app |
Same issue here. Receiving this crash from time to time via Sentry. Details:
|
@WingedDoom @xlbs-rm If you updating to the latest version of |
@HazAT oh, thank you for the information! Updating sentry fixed the issue indeed. |
@HazAT did you fix this by just removing getQueueName functionality or did you find the root cause for this crash? If so would you mind creating a Pull Request so that this gets fixed for everyone? |
@harp79 We just removed it for now since we did not have the time to fully dig into the issue. |
We're using Sentry-Cocoa 4.1.0 and we're still seeing this issue. |
Anybody else running across this still? |
Yep, still an issue. Our number one (and six for some reason) crasher as reported by Crashlytics |
Same here My understanding is that the Sentry 4.1.0 doesn't use this any more. |
in KSThread.c, EXC_BAD_ACCESS
-->if(dispatch_queue_ptr == NULL || idInfo->thread_handle == 0 || *dispatch_queue_ptr == NULL)
{
KSLOG_TRACE("This thread doesn't have a dispatch queue attached : %p", thread);
return false;
}
Crashed: Thread
0 KSCrash 0x10056738c ksthread_getQueueName (KSThread.c:82)
1 KSCrash 0x100567370 ksthread_getQueueName (KSThread.c:75)
2 KSCrash 0x10053f6c8 monitorCachedData (KSCrashCachedData.c:84)
3 libsystem_pthread.dylib 0x18d021850 + 240
4 libsystem_pthread.dylib 0x18d021760 _pthread_start + 282
5 libsystem_pthread.dylib 0x18d01ed94 thread_start + 4
The text was updated successfully, but these errors were encountered: