-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky KFServing e2e tests with 404s #604
Comments
@yuzisun Seems the problem cannot be reproduced 100%. Thanks |
@cliveseldon @jinchihe e2e test polls the service ready condition and then sends the request to the service, looks it is a real bug in controller how we report readiness. I suspect here is the issue, we call creating virtual service and immediately mark it "ready" https://github.com/kubeflow/kfserving/blob/master/pkg/controller/inferenceservice/resources/istio/virtualservice.go#L286. |
@yuzisun Yes, I check the E2E test, I think that's not env problem, may be our code issue. |
/P1 |
/priority p1 |
/close |
@yuzisun: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue still persists. When I removed the time.sleep from the test as part of the Enhance CI PR, I am able to observe this behaviour in CI.
|
/kind bug
What steps did you take and what happened:
What did you expect to happen:
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: