Replies: 4 comments 2 replies
-
|
thank you! looks like it hit the precondition that "should not happen" 
I can easily reproduce it. I don't have this action enabled on my side, that's why it never occurred to me ;) |
Beta Was this translation helpful? Give feedback.
-
|
Thats entirely fair, I use it a bunch* but I had accidentally triggered it which is why I noticed.
|
Beta Was this translation helpful? Give feedback.
-
|
fixed on |
Beta Was this translation helpful? Give feedback.
-
|
Thank you! Can confirm that definitions now correctly show for the word tapped! Woot! However the crash, because of the precondition, can/does still occur if you accidentally do the three finger tap on a space / newline between the paragraphs. (For instance three finger tap on line 2) But it only seems to do it in that circumstance, and I tried to crash it :) Aside: three finger tap on the annotation generates the log |
Beta Was this translation helpful? Give feedback.
-
|
right! I didn't test that. It should be handled now. |
Beta Was this translation helpful? Give feedback.
-
|
Perfect ✅ |
Beta Was this translation helpful? Give feedback.
-
Was recording a video showing that the lookup action (three finger tap) wasn't behaving correctly in the TextEdit sample app, when I clicked on another word and the app crashed and opened debugger in STTextView/NSTextContentManager+Helpers.swift:55: Precondition failed
macOS 13.4, Xcode 14.3.1, STTextView 0.7.2
(Vid 1 I had the box for screen record too small and so it chops part of the definitions off, but its enough you can still see its the wrong word & definition)
https://github.com/krzyzanowskim/STTextView/assets/3006/5c2a025f-2286-4ca7-8c69-1e69bf875932
Another video, showing to close to beginning and it won't show any definition for 3 finger tap. Further down it shows for a word above where I tapped and then the crash.
https://youtu.be/MrreVUXcZDs (video was 30mb, max size for here is 10mb, apologies)
Beta Was this translation helpful? Give feedback.
All reactions