Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup on bootstrap fail #369

Open
thomastaylor312 opened this issue Sep 2, 2020 · 6 comments · May be fixed by #705
Open

Cleanup on bootstrap fail #369

thomastaylor312 opened this issue Sep 2, 2020 · 6 comments · May be fixed by #705
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thomastaylor312
Copy link
Member

thomastaylor312 commented Sep 2, 2020 •
edited

Right now, if the bootstrap process fails part of the way through, it leaves a bunch of invalid resources around in the cluster (like the old CSR). As a new user, it would be helpful if I didn't have to clean these up manually after a bootstrap fail.

Requirements:

  • Clean up auth certificate CSR on failure

Questions:

  • Should we clean up anything else? Cleaning up local config sounds dangerous, as it still could be valid and would force bootstrapping again
@thomastaylor312 thomastaylor312 added the enhancement New feature or request label Sep 2, 2020
@thomastaylor312
Copy link
Member Author

This would probably be a good first issue once we answer the outstanding question

@itowlson
Copy link
Contributor

itowlson commented Sep 7, 2020

If "bootstrap fail" refers to the bootstrapping that happens within the kubelet, then we should delete only the CSR; leave all the script stuff intact. The user should be able to run the kubelet again and re-attempt the CSR creation and approval using the existing bootstrap config.

If bootstrap.sh fails then I think the user can just run it again - there won't be any conflicts there will there? So the CSRs are the only things that need to be dealt to.

@thomastaylor312
Copy link
Member Author

Yep, I believe so. Just wanted to check so we didn't do anything stupid

@thomastaylor312 thomastaylor312 added the good first issue Good for newcomers label Sep 8, 2020
@VishnuJin
Copy link
Contributor

hey guys, I would like to work on this enhancement, any suggestions please !!

@thomastaylor312
Copy link
Member Author

Just make sure to implement the point under Requirements in the issue above!

VishnuJin added a commit to VishnuJin/krustlet that referenced this issue Dec 8, 2021
@VishnuJin
feature krustlet#369 add steps to Cleanup on bootstrap fail
c819bd3
@VishnuJin
Copy link
Contributor

hi @thomastaylor312 sorry I was kinda occupied for the past couple of months,
gave this feature a try #705 please let me know if it's the right approach or I'm completely off track :)

VishnuJin added a commit to VishnuJin/krustlet that referenced this issue Dec 8, 2021
@VishnuJin
feature krustlet#369 add steps to Cleanup on bootstrap fail
098e060 
Signed-off-by: VishnuJin <vishnujin@outlook.com>
@VishnuJin VishnuJin linked a pull request Dec 8, 2021 that will close this issue
Open
VishnuJin added a commit to VishnuJin/krustlet that referenced this issue Dec 8, 2021
@VishnuJin
feature krustlet#369 add steps to Cleanup on bootstrap fail
e49e9e9 
Signed-off-by: VishnuJin <vishnujin@outlook.com>
VishnuJin added a commit to VishnuJin/krustlet that referenced this issue Dec 8, 2021
@VishnuJin
feature krustlet#369 add steps to Cleanup on bootstrap fail
95429a6 
Signed-off-by: VishnuJin <vishnujin@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature #369 add steps to Cleanup on bootstrap fail VishnuJin/krustlet
3 participants
@itowlson @thomastaylor312 @VishnuJin