@thomastaylor312 Hey i am just getting started with rust and thought this was a good way to get started, any pointers on where I can begin ?

@sladyn98
I haven't spent much time looking, but I think this should be a good starting point: https://github.com/deislabs/krustlet/blob/c781a9816858607647108d2157c7c5c1ca004a35/crates/kubelet/src/config.rs#L338

That code should be common to most ways of building a config and can return an error during initialization, which should be suitable for this check.

Hi @sladyn98, thanks for offering to help! So when I was double checking things, I actually think we'd want to verify this in the Kubelet::new function: https://github.com/deislabs/krustlet/blob/20c00115d3af460fe7740d6a07589b25578fcaef/crates/kubelet/src/kubelet.rs#L42

The reason being is that the config file and command line flag stuff is optional, which means a user can generate a Config on their own and have it not be valid. I think at minimum, it should check the two pieces of data specified in this issue. A stretch goal (but definitely not required for a first time issue like this) would be to add a validate function to the Config so any future data validation can be added there.

Hope that helps! And thanks again for the help

Hi, I found this issue was not updated since June 5th and I'm been following Krustlet community. So I submit a new PR, could you please help review this PR when it is convenient. Thanks.