Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate modifier when assigning to a button #27

Open
nqv opened this issue Jan 6, 2021 · 1 comment
Open

Duplicate modifier when assigning to a button #27

nqv opened this issue Jan 6, 2021 · 1 comment
Assignees
Labels

Comments

@nqv
Copy link

nqv commented Jan 6, 2021

When trying to reset the buttons to default settings (LeftCtrl and LeftAlt), the modifier gets duplicated

./ratslap --modify f3 --g6 'LeftCtrl' --g7 'LeftAlt' -p f3
...
  G6:                  LeftCtrl + LeftCtrl
  G7:                  LeftAlt + LeftAlt

I'd expect:

  G6:                  LeftCtrl +
  G7:                  LeftAlt +
@nqv nqv changed the title Duplicate modifier when assigng to a button Duplicate modifier when assigning to a button Jan 6, 2021
@krayon
Copy link
Owner

krayon commented Mar 25, 2021

Thanks @nqv . This is a semantic thing really I think. The event must always generate a key, with optional modifiers. This means that LeftCtrl + LeftAlt (LeftCtrl modifier, LeftAlt key) is actually different than LeftAlt + LeftCtrl (LeftAlt modifier, LeftCtrl key). So LeftCtrl + LeftCtrl is LeftCtrl key with a LeftCtrl modifier 🤔

... I guess you're right though, it should probably just be the key event so the output should be:

  G6:                  LeftCtrl
  G7:                  LeftAlt

@krayon krayon removed the wontfix Not a bug label Mar 25, 2021
@krayon krayon self-assigned this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants