Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluebird is error-handing our error-handler #410

Open
jasisk opened this issue Aug 21, 2015 · 3 comments
Open

bluebird is error-handing our error-handler #410

jasisk opened this issue Aug 21, 2015 · 3 comments
Projects

Comments

@jasisk
Copy link
Member

jasisk commented Aug 21, 2015

Need to look into this some more but bluebird assumes endgame isn't there to catch the uncaught exception on app emitting error. Eats it up, prevents the app from tearing down.

@jasisk jasisk changed the title bluebird is error-handing or error-handler. bluebird is error-handing our error-handler Aug 31, 2015
@grawk
Copy link
Member

grawk commented Dec 24, 2015

I think I ran into this as well.. I introduced an error into the onconfig handler and got this output:

[development] Listening on http://localhost:8000
Possibly unhandled Error: boom
    at onconfig (/Users/medelman/src/krakex/kraken-example-with-passport/lib/spec.js:29:18)
    at promisified (eval at makeNodePromisifiedEval (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/promisify.js:198:12), <anonymous>:3:213)
    at tryCatch1 (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/util.js:63:19)
    at Promise$_callHandler [as _callHandler] (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/promise.js:695:13)
    at Promise$_settlePromiseFromHandler [as _settlePromiseFromHandler] (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/promise.js:711:18)
    at Promise$_settlePromiseAt [as _settlePromiseAt] (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/promise.js:868:14)
    at Promise$_settlePromises [as _settlePromises] (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/promise.js:1006:14)
    at Async$_consumeFunctionBuffer [as _consumeFunctionBuffer] (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/async.js:74:12)
    at Async$consumeFunctionBuffer (/Users/medelman/src/krakex/kraken-example-with-passport/node_modules/kraken-js/node_modules/bluebird/js/main/async.js:37:14)
    at process._tickCallback (node.js:355:11)

@grawk
Copy link
Member

grawk commented Dec 24, 2015

I would have assumed a process.exit on throwing that error ^

@xjamundx
Copy link
Contributor

xjamundx commented Sep 22, 2017

Doing some research with errors in kraken right now and remembering this one. Shouldn't it force a crash here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Triage
Doing
Development

No branches or pull requests

3 participants