Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors from external scripts #19

Open
1 of 3 tasks
kpcyrd opened this issue Mar 20, 2018 · 0 comments
Open
1 of 3 tasks

Handle errors from external scripts #19

kpcyrd opened this issue Mar 20, 2018 · 0 comments
Labels
runtime Related to the badtouch lua runtime

Comments

@kpcyrd
Copy link
Owner

kpcyrd commented Mar 20, 2018

The python example in the readme currently doesn't do any error handling, so a network failure would not result in a retry but marks the attempt as failed.

The python example should use a different error code for exceptions and the lua wrapper should handle this error.

  • there should be a way to test if there has been an error by querying the runtime state
  • if the lua script returns an error while an error has already been recorded, the error should be chained. Error { last_error, next: Error { previous_error } }
  • error handling should be unified, if the lua function returns a string, this should cause an Err(_)
@kpcyrd kpcyrd added the runtime Related to the badtouch lua runtime label Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime Related to the badtouch lua runtime
Projects
None yet
Development

No branches or pull requests

1 participant